assigned error return to variable ret is not being used in function libtypec_dbgfs_get_alternate_modes

[ColinIanKing]

In function libtypec_dbgfs_get_alternate_modes() the failed call to get_ucsi_response are assigning -1 to ret to indicate an error has occurred but this variable is not being read so the failure is effectively being silently ignored. Is that expected to ignore these failure cases?

                        if(ret)
                        {
                                ret = get_ucsi_response(buf);
                                if(ret<31)
                                        ret = -1;

                                alt_mode_data[i].svid    = buf[28] << 12 | buf[29] <<8 | buf[30] << 4 | buf[31];
                                alt_mode_data[i].vdo     = buf[24] << 12 | buf[25] <<8 | buf[26] << 4 | buf[27];

                                if(alt_mode_data[i].svid == 0)
                                        break;
                        }

[ColinIanKing]

Same for libtypec_dbgfs_get_pdos_ops() too, ret being assigned but not checked.

[Rajaram-Regupathy]

resolved