search

RajatShukla / getpaid

Automatically exported from code.google.com/p/getpaid
0 stars 0 forks source link

Merchant email notification template on checkout causes order loss but billing success #124

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. set merchant email, name in GetPaid setup area; leave email
notifications "on"
2. Place an order
3. See the error...

What is the expected output? What do you see instead?

This should send customer and merchant an email and record the order.
Instead, it spits out an error and loses the order (though the pay
processing goes through!):

 This site encountered an error trying to fulfill your request. The errors
were:

Error Type
    ComponentLookupError
Error Message
    (<InterfaceClass
Products.PloneGetPaid.interfaces.INotificationMailTemplate>,
<getpaid.core.order.Order object at 0xc0ecf50>, 'merchant-new-order')

Original issue reported on code.google.com by cjj.ifpe...@gmail.com on 5 Oct 2007 at 5:33

GoogleCodeExporter commented 9 years ago 
I think the adapter issue from the email template got fixed. One problem is 
that the
site still hangs if the email notifications are set to "on" but it doesn't work 
(ie
no mailhost) - see error below. 

We should have a graceful handling of this (ie if set to "on" but doesn't work, 
don't
send the email and return an error message "Notification email could not send 
due to
a problem in the site settings. The status of the order is displayed below" The 
order
should complete if the transaction happened with the pay processor!!

2007-10-14 12:00:40 INFO Zope Ready to handle requests
2007-10-14 12:09:49 ERROR Zope.SiteErrorLog
http://localhost:8080/pgp/@@getpaid-checkout-wizard
Traceback (innermost last):
  Module ZPublisher.Publish, line 115, in publish
  Module ZPublisher.mapply, line 88, in mapply
  Module Products.PDBDebugMode.pdbzope.runcall, line 60, in pdb_runcall
  Module ZPublisher.Publish, line 41, in call_object
  Module Products.PloneGetPaid.browser.checkout, line 279, in __call__
  Module zope.formlib.form, line 769, in __call__
  Module Products.PloneGetPaid.browser.checkout, line 428, in update
  Module Products.Five.formlib.formbase, line 54, in update
  Module zope.formlib.form, line 750, in update
  Module zope.formlib.form, line 594, in success
  Module Products.PloneGetPaid.browser.checkout, line 479, in makePayment
  Module hurry.workflow.workflow, line 237, in fireTransition
  Module zope.event, line 23, in notify
  Module zope.app.event.dispatching, line 66, in dispatch
  Module zope.component, line 181, in subscribers
  Module Products.Five.site.localsite, line 136, in subscribers
  Module zope.interface.adapter, line 481, in subscribers
  Module zope.app.event.objectevent, line 192, in objectEventNotify
  Module zope.component, line 181, in subscribers
  Module Products.Five.site.localsite, line 136, in subscribers
  Module zope.interface.adapter, line 481, in subscribers
  Module Products.PloneGetPaid.notifications, line 107, in sendNotification
  Module Products.SecureMailHost.SecureMailHost, line 160, in send
  Module Products.MailHost.MailHost, line 144, in send
  Module Products.SecureMailHost.SecureMailHost, line 268, in _send
  Module Products.SecureMailHost.mail, line 99, in send
  Module smtplib, line 244, in __init__
  Module smtplib, line 310, in connect
error: (111, 'Connection refused')
> 
/home/cjohnson/software/getpaid/getpaid-wc/getpaid.buildout/smtplib.py(310)conne
ct()
-> raise socket.error, msg

Original comment by cjj.ifpe...@gmail.com on 14 Oct 2007 at 10:32

GoogleCodeExporter commented 9 years ago

Original comment by samo.opu...@gmail.com on 14 Oct 2007 at 12:09

GoogleCodeExporter commented 9 years ago

Original comment by samo.opu...@gmail.com on 14 Oct 2007 at 12:09

GoogleCodeExporter commented 9 years ago 
Exception now silently caught.

Instead of silently catching it, a message should be written to the error log.

Original comment by samo.opu...@gmail.com on 15 Oct 2007 at 5:31

GoogleCodeExporter commented 9 years ago 
So what is the status on email notifications now? is it working? because I don't
receive anything when I buy a product, even if it is setup in the site setup to
receive emails.

Original comment by lucielej...@gmail.com on 16 Nov 2007 at 4:17

GoogleCodeExporter commented 9 years ago 
Finally the email notifications are working. To be able to receive the merchant 
email notification, be sure to set 
the merchant email address in Get Paid Setup -> Site Profile.

Original comment by lucielej...@gmail.com on 19 Nov 2007 at 6:26

GoogleCodeExporter commented 9 years ago 
closing this issue as i dont think it has been replicated

Original comment by cjj.ifpe...@gmail.com on 4 Apr 2008 at 2:40