RajatShukla / getpaid

Automatically exported from code.google.com/p/getpaid
0 stars 0 forks source link

including jquery.js twice breaks other javascript components #294

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
plonegetpaid includes jquery-1.2.1.pack.js in all getpaid related view via
content-space-template.pt

including an older version of jquery after the newer one can cause other
scripts (eg collective.superfish) not to work anymore.

i think this comes from a time where plone did not ship w/ jquery at all.
recent plone installation come with much newer versions of jquery.

for recent installation we can simply remove the include in
javascript_head_slot.
this will most probably break getpaid installations on older plone versions
that don't ship with jquery.

i don't know which plone versions are affected by this, and if we should
care or simply add a note in the changelog.
eg: that users need to make sure jquery.js gets included in
portal_javascript in their policy product if they run getpaid on plone < 3.X?

Original issue reported on code.google.com by haral...@gmx.at on 7 Jun 2010 at 9:12

GoogleCodeExporter commented 8 years ago
i removed jquery (and jquery.form which was not used in any template)
now that a newer version of jquery is used, enabling and disabling the
shippingaddress does not work anymore.

checkout-process.js needs to be fixed.

Original comment by haral...@gmx.at on 7 Jun 2010 at 10:18

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
fixed in http://code.google.com/p/getpaid/source/detail?r=3670

the javascript is now hooked up via jQuery() instead of calling
<script>enableSth();</script> in the template

Original comment by haral...@gmx.at on 7 Jun 2010 at 12:10