RakambdaOrg / ChannelPointsMiner

Watch Twitch streams and earn channel points
GNU Affero General Public License v3.0
67 stars 11 forks source link

Add setting to dismiss known global ids that hide normal drops #844

Closed Rakambda closed 1 month ago

Rakambda commented 1 month ago

Pull Request Etiquette

Thanks @jabbink

Checklist

Type of change

New Feature

Description

Twitch is now pushing the Apple TV+ "drop" on every channel, which makes drop recognition impossible (available drops highlight service only returns 1 drop, the Apple TV+ one) there's this GQL request to dismiss a drop campaign which I personally call in DropsPriority whenever I run into a sub requirement only drop, or a reward campaign.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.44%. Comparing base (adfb8aa) to head (5bcaaea). Report is 7 commits behind head on develop.

Files Patch % Lines
...elpointsminer/miner/runnable/UpdateStreamInfo.java 95.65% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #844 +/- ## ============================================= + Coverage 85.32% 85.44% +0.11% - Complexity 1109 1118 +9 ============================================= Files 201 202 +1 Lines 3483 3511 +28 Branches 262 263 +1 ============================================= + Hits 2972 3000 +28 Misses 456 456 Partials 55 55 ``` | [Flag](https://app.codecov.io/gh/RakambdaOrg/ChannelPointsMiner/pull/844/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RakambdaOrg) | Coverage Δ | | |---|---|---| | [unittests-miner](https://app.codecov.io/gh/RakambdaOrg/ChannelPointsMiner/pull/844/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RakambdaOrg) | `85.82% <96.77%> (+0.11%)` | :arrow_up: | | [unittests-viewer](https://app.codecov.io/gh/RakambdaOrg/ChannelPointsMiner/pull/844/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RakambdaOrg) | `58.33% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RakambdaOrg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.