search

Rakefire / jekyll-ical-tag

Pull ICS feed and provide a for-like loop of calendar events in jekyll's liquid tag
7 stars 6 forks source link

Dereference variables without using `dig` #18

Closed rickychilcott closed 4 years ago

rickychilcott commented 4 years ago

After reviewing https://github.com/jekyll/jekyll-gist/blob/master/lib/jekyll-gist/gist_tag.rb#L20-L43

It's clear there is a context.key? and context[] method to dereference all types of variables

Close #17 Close #19

fabacab commented 4 years ago

Not directly related to this issue, but during testing of this patch I found another spot in the code where one of those "incompatible encoding" errors raised its head again. I've sent you a patch in #20 to address that in this patch.

rickychilcott commented 4 years ago

@meitar tested and all of my tests appear to correct most, if not all issues. Merging and will cut new release