search

Rakefire / jekyll-ical-tag

Pull ICS feed and provide a for-like loop of calendar events in jekyll's liquid tag
7 stars 6 forks source link

Fixes #26, fixes #27: Pass tag attributes to new coordinator. #29

Closed fabacab closed 3 years ago

fabacab commented 3 years ago

Probably not the most elegant solution, but in testing the latest release I noticed that none of the ical tag attributes were being recognized. I traced this down to the fact that there was no longer a place where the tag's attributes, despite being recognized and set as class attributes, were being passed to the newly introduced CalendarFeedCoordinator object, which is now what calls the iCalendar feed parser. That's where these values ultimately have to go.

This commit simply passes them along to the coordinator via its constructor method.

rickychilcott commented 3 years ago

Thanks. I'd really like to have an integration test to check these things, but that's a bunch more work for little gain.