search

Rakefire / jekyll-ical-tag

Pull ICS feed and provide a for-like loop of calendar events in jekyll's liquid tag
7 stars 6 forks source link

drop first instance of reccurences to prevent duplicates #47

Closed whatnotery closed 1 month ago

whatnotery commented 1 month ago

Per https://github.com/Rakefire/jekyll-ical-tag/issues/45#issuecomment-2238009553 duplicates are occurring on the first occurrence of recurring events so I've made a change to drop the first occurrence of recurring events so that the initial event is not duplicated from the initially parsed event and the first from the recurrence array

this should resolve #45

whatnotery commented 1 month ago

ok so the drop(1) was deleting the first occurence even if it wasn't butted up to the first event instance. I've refactored in a somewhat less performant way but that seems to solve both issues though

whatnotery commented 1 month ago

@rickychilcott I made changes here last night that solve the issue with drop(1)