[Bug] Fix the zero calculation in Pythagorean Theorem Calculator

srilekha279 commented 3 months ago

Description

The current implementation of the hypotenuse calculator has a bug where it incorrectly calculates the hypotenuse when one of the sides is entered as zero.

Steps to Reproduce:

Open the calculator and input 0 as one of the sides (e.g., side a).
Enter a non-zero value as the other side (e.g., side b).
The calculator incorrectly calculates the hypotenuse.
What I want to improve
Fix the bug
Input Handling:

Allow users to input values into three fields: side a, side b, and hypotenuse. Calculations: Implement logic to:
Calculate the hypotenuse if two sides are given.
Calculate the missing side if the hypotenuse and one side are given.
Validate the triplet if all three sides are given.

Screenshots

Screenshot (922)

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

github-actions[bot] commented 3 months ago

Hey @srilekha279, Welcome to the project CalcDiverse! 🎊 Thanks for opening an issue! 🙌 Please wait for the issue to be assigned. Happy Coding!! ✨

Rakesh9100 commented 3 months ago

Go ahead @srilekha279

srilekha279 commented 3 months ago

Go ahead @srilekha279

Should I fix the bug first and then raise a separate issue for the enhancement?

Rakesh9100 commented 3 months ago

What kind of enhancement @srilekha279

srilekha279 commented 3 months ago

What kind of enhancement @srilekha279

Instead of taking two sides as input, I want to take 3 sides as input and calculate the missing side if the hypotenuse and one side are given, calculate the hypotenuse if 2 other sides are given and validate the triplet if all three sides are given.

Rakesh9100 commented 3 months ago

You just fix the bug in this issue by creating a PR, we already have Pythagorean Triples Calculator @srilekha279

srilekha279 commented 3 months ago

You just fix the bug in this issue by creating a PR, we already have Pythagorean Triples Calculator @srilekha279

I understand that the current Pythagorean Triples Calculator validates triplets, but I believe adding the following feature will significantly enhance its functionality

Calculate Missing Side: If the hypotenuse and one side are given.

The current Pythagorean Triplet Calculator only checks whether a triplet is valid. I propose to calculate any side of a right triangle, not just the hypotenuse.

Screenshot (924)

srilekha279 commented 3 months ago

@Rakesh9100 Please accept my pull request.

github-actions[bot] commented 3 months ago

Hello @srilekha279! Your issue #1811 has been closed. Thank you for your contribution!! 🙌

Rakesh9100 / CalcDiverse