Open vrurg opened 4 years ago
Would like to have at least two approvals to merge.
I'm not sure such a thing would be enforceable, and what would constitute a conflict of interest?
If an active member would not recuse themselves from a vote because they perceive a conflict of interest, then I think all is lost already. Because then it is more about politics then it is about content anymore.
So I'm leaning against merging this PR.
This could serve as undeniable rule for vote calculation. I.e. nobody can't stop one from voting, but if there is a rule to ignore his voice unconditionally – that's different story.
@lizmat - a conflict of interest would be someone with W
permissions writing their nominations directly to master
rather than going through a PR like the rest of the community has to do causing a "some are more equal than others" mentality among people with W
perms.
As evidence of this, please see all of the current nominations.
@tony-o : it was my understanding that anybody that has a commit bit in any of the rakudo / nqp / MoarVM repos, would have write access here. If that is not the case, we should fix that.
@lizmat - i definitely do not have write or merge access in this repo :-)
@vrurg It appears that not everybody in the rakudo / nqp / MoarVM repos has write access to this repo. It also appears that my Github access management Foo is too low to reliably fix this without messing everything up. Could you tell me how to do this and/or make sure that everybody in the rakudo / nqp / MoarVM repos has write access here ?
@tony-o Until we've fixed this, please be assured that any PR for a nomination will be merged as soon as anybody with write access finds out about it.
@lizmat thank you
@vrurg It appears that not everybody in the rakudo / nqp / MoarVM repos has write access to this repo.
It was the initial intention. I don't remember if we discussed opening the repo, might have just missed it. Opened write access to Raku team.
@tony-o can you check if you can write now?
It also appears that my Github access management Foo is too low to reliably fix this without messing everything up.
This is rather confusing to me now because you're in the current RSC team which has Admin role for this repository. Either I miss something it how GitHub functions or there is a bug of some kind.
@vrurg: it's not that I could not, it's that I wasn't sure I was doing the right thing :-)
@lizmat Neither do I. :) Is Raku team sufficient? I can add rakudo and moar teams, but is it necessary?
@vrurg perhaps add those as well, it couldn't hurt, is my understanding?
I can write now, thank you @vrurg @lizmat
@lizmat It seems that there is no technical way to add MoarVM and Rakudo commiters. MoarVM doesn't have a formal team. Rakudo does have it but it's marked as Secret and thus can't be seen outside of the org.
Prevent conflict of interests