search

Raku / App-Rakubrew

Raku environment manager
https://rakubrew.org/
Other
26 stars 13 forks source link

Adds zef version to build, refs #31 #32

Closed JJ closed 3 years ago

JJ commented 3 years ago

Creates a new argument to build-zef that, when present, downloads the specific version of zef, and installs that one instead of the last one, which is the one built-now. When accepted (and after adding it to the docs) closes #31

patrickbkr commented 3 years ago

I just noticed, that the clone logic is only triggered, when there is no pre-existing repo. Otherwise it will only pull in the existing one. That should be accounted for. (I.e. not just silently ignore the zef version argument in that case).

JJ commented 3 years ago

I just noticed, that the clone logic is only triggered, when there is no pre-existing repo. Otherwise it will only pull in the existing one. That should be accounted for. (I.e. not just silently ignore the zef version argument in that case).

But if the repository has been cloned, the tags are going to be there anyway. The logic will be different, but it's going to work, I think. Let me check.

JJ commented 3 years ago

I just noticed, that the clone logic is only triggered, when there is no pre-existing repo. Otherwise it will only pull in the existing one. That should be accounted for. (I.e. not just silently ignore the zef version argument in that case).

But if the repository has been cloned, the tags are going to be there anyway. The logic will be different, but it's going to work, I think. Let me check.

Actually, not, because I was doing a shallow clone, so it the previous one was a tag clone, only that tag was available. Back to deep clone now, although we can reformulate it with shallow clones if a small speed bump is needed.

patrickbkr commented 3 years ago

@JJ Thanks for pushing through with this!

JJ commented 3 years ago

@JJ Thanks for pushing through with this!

Glad to be of help.