Raku / Pod-To-HTML

Convert Raku docs to shiny HTML
Artistic License 2.0
12 stars 19 forks source link

Docs build is not tested #84

Open JJ opened 4 years ago

JJ commented 4 years ago

In some cases and for some versions (probably not the last one), instead of using the default mustache template, it's using the default pod-to-html template, as shown here. Refs Raku/documentable#142. It does work correctly with the configuration indicated in the comments. Takes a long time, though. The problem becomes now to integrate those tests as spec for this module.

Altai-man commented 4 years ago

Hi. Can you please specify exact reproduce steps for this, what was expected and how it behaves instead?

JJ commented 4 years ago

I'm trying to reproduce it. So far, it does not seem to happen with Pod::To::HTML 0.7.1 and Raku 2020.10

JJ commented 4 years ago

At any rate, we need to integrate any test for this module done in Documentable here; that should be spec for this module.

JJ commented 4 years ago

OK, it seems to work now with, if not the latest version of Pod::To::HTML, the next-to-last version. I'm testing for the last version anyway.

JJ commented 4 years ago

... but it's broken in 0.8: Captura de pantalla de 2020-10-26 12-11-32 ... it's missing title and the small style snip that's used by default.

Altai-man commented 4 years ago

Can you post commands you are running, please?

JJ commented 4 years ago
  1. Fresh install of raku 2020.10
  2. Install Pod::To::HTML from source, zef install .
  3. Install documentable from zef, version 2.0.1
  4. documentable start -a -v --highlight

Title is missing from index.html and 404.html (as shown above). The <style> section (which, TBH, I'm not so totally sure about) is missing from all Captura de pantalla de 2020-10-26 12-55-16

These are only the errors that pop up. The problem is that, again, it's not tested against its main use, so we don't know if there are any other errors somewhere.

JJ commented 4 years ago

BTW, it takes 976 seconds, which is roughly 30% more that it takes with version 0.7.1. It might still be a good idea to do a proper release of 0.7.1 after all.

Altai-man commented 4 years ago

Thank you! I will look into it after $dayjob.

Altai-man commented 4 years ago

BTW, it takes 976 seconds, which is roughly 30% more that it takes with version 0.7.1. It might still be a good idea to do a proper release of 0.7.1 after all

Can confirm this. I think we will have it faster than before with Cro::WebApp (once https://github.com/Raku/Pod-To-HTML/issues/82 is resolved).

Title is missing from index.html and 404.html

I had the same behavior with Pod::To::HTML 0.7.1. Glancing at the code yesterday I am not sure where the title for those pages was set at all.