search

Raku / atom-language

Atom/Github Raku Syntax Highlighting Support 🦋
Other
24 stars 11 forks source link

Linguist fixes based on raiph's PR #103

Closed 2colours closed 1 year ago

2colours commented 1 year ago

I modified the Raku sources (also did some unquoting the escape the... escape hell), then generated the grammars using generate-grammars.raku (get used to it, folks).

The changes in the JSON file should be the same as for https://github.com/Raku/atom-language/pull/102.

2colours commented 1 year ago

@raiph ping - do you want to check this modification based on your PR? I would like to merge it as soon as possible, preferably within a few weeks.

raiph commented 1 year ago

I'm having a tough time contributing anything online right now for a wide range of reasons and even this seemingly simple task is beyond me. (I can barely read the screen as I type this, with the best I can manage being a screen area an inch or so deep and and few wide so I can make sure words in this comment are spelled right being about as good as I can get things! (Don't ask. Maybe in a month when I'm past all the issues that are currently piling on. OK, to at least explain the screen thing I'm outdoors where I can get slow/unreliable wifi but the sun is shining and in the shade the wifi connection breaks...)

Suffice to say, I can't check this merge for three main reasons. 1, I can't reliably read the characters on the screen. 2) I can't relax enough to focus. 3) Even if I could fix 1 and 2 I can't test any of it.

If it's not a big deal if merging it breaks things, because you can just back the changes out and there'll not be any significant consequence of that, then merging sounds plausibly reasonable. Otherwise, I hope to be living in my new home, and have a proper internet connection, and be able to sort out 1 and 2 above (but still not 3) within at most a month (and hopefully sooner).

2colours commented 1 year ago

Thank you for the follow-up!

No worries. To be honest, I haven't made up my mind if I want to rush forward recklessly, do further investigation about getting a working test environment again, or put it aside until you can take a more elaborate look on things... either way, your contribution is welcome and I'm happy for anybody getting involved in any way to any extent. ^^

2colours commented 1 year ago

@raiph so do you think it is okay if I merge this now? Don't worry about the tests; eventually, there will be a new way for testing but right now it doesn't matter that much.

raiph commented 1 year ago

I'd not bet money it's OK because I haven't tested it, but then it's low stakes right? If it's wrong, someone says something, you back it out, no harm done, right? If so, feel free to merge it.