search

Raku / atom-language

Atom/Github Raku Syntax Highlighting Support 🦋
Other
24 stars 11 forks source link

Character Classes Missing { } #104

Closed bscan closed 10 months ago

bscan commented 11 months ago

Hi @2colours, I reviewed the issue brought up in: https://github.com/microsoft/vscode/issues/168319#issuecomment-1715726598

The issue is that https://github.com/Raku/atom-language/pull/103/commits/83d24d50bc57e9be45fcded42bed79d83da4af59 replaced p{Alpha} by \\pL\\pM which are not regex character classes in Oniguruma regexes. They should be \\p{L}\\p{M} instead.

The left shows with \\pL\\pM and the right shows with \\p{L}\\p{M}

\pL is a valid PCRE character class, and I see the idea came from https://github.com/Raku/atom-language/pull/102 to use them since Linguist uses PCRE. \p{L} is valid in both PCRE and Oniguruma

image

2colours commented 11 months ago

Hi,

what can I say... it seems fairly annoying that we get problems merely because the same data is used simultaneously, by incompatible systems. (What is even more annoying is when you get to closed doors because you fixed some problems for a different user.)

If you are confident that this is the problem - it seems like you have invested into figuring it out - could you please submit a modified version as well? I will eventually get to it unless I forget but this seems like a good opportunity to lure more people into the way things work with this repo. :)

Cheers

2colours commented 10 months ago

@bscan ping - in case you missed the message. I might do it next week sometime if you don't want to get involved.

2colours commented 10 months ago

Okay, done now with https://github.com/Raku/atom-language/commit/ee64f968c3b9f28f29cd58832ac5d7a216408131 - please re-open if there are further problems with it.

bscan commented 9 months ago

Thanks @2colours! Sorry for not getting back to you on this one. However, I just checked out https://github.com/alexr00/testraku and copied in your fixes for testing, and I can confirm that your new version fixes the issue. Thanks!

image