Raku / atom-language

Atom/Github Raku Syntax Highlighting Support 🦋
Other
24 stars 11 forks source link

Modify META6.json highlighter #105

Closed sumanstats closed 1 year ago

sumanstats commented 1 year ago
2colours commented 11 months ago

The META6 parser at https://github.com/jonathanstowe/META6 also uses True and False in addition to true and false Highlight those too !

@sumanstats sorry, are you sure about this? What does it mean that it "uses them"? True and False are not valid in JSON, that's for sure.

2colours commented 11 months ago

Oh right... the bigger problem is that you modified the output file, not the source file. https://github.com/Raku/atom-language/blob/master/CONTRIBUTING.md#show-me-the-source-already

Please, don't merge pull requests without confirming that the modifications are at least in accordance with the way the software works.

2colours commented 11 months ago

Now I backported the modifications but the question about uppercase true and false still applies.