Raku / doc-website

Tooling to build/run the documentation website
Artistic License 2.0
7 stars 10 forks source link

resolves issue #303 #312

Closed finanalyst closed 11 months ago

finanalyst commented 11 months ago
finanalyst commented 11 months ago

@dontlaugh or @coke this patch sync's options-search with new-raku. Comments in issue #303 indicate the changes address the issue.

coke commented 11 months ago

This is a huge improvement, thank you.

One request: can you make the <a> wrap both the title and the description? If I search for say and get a response like

say
From type...

I can command-click on the say to open a new window but not the highlighted description underneath. Would be great to be able to move down the list and not have to worry about targeting the title on each box as I click.

Thanks again, this is great!

coke commented 11 months ago

Note: could also have a separate <a> around the description with the same link, doesn't have to be a single anchor across both bits of text.

dontlaugh commented 11 months ago

I'm away from my computer right now, but how does it behave with middle click? Typically "Mouse3" I think.

coke commented 11 months ago

I'm away from my computer right now, but how does it behave with middle click? Typically "Mouse3" I think.

Works on my windows box (opens a new window if you middle click on the title)

finanalyst commented 11 months ago

@coke The <a> can go around the 'value' and the 'description', a trivial fix. But it screws up the CSS, so it may take a bit of time to sort it.

finanalyst commented 11 months ago

widened anchor and fixed css. Seems to look ok on new-raku

coke commented 11 months ago

This seems better. One question (for anyone) - should I expect the results div to stay up when I command click on a mac (it opens the results in a new tab behind) - I think at one point it kept it open, but the current behavior is to open the new tab and close the search results on the original page.

finanalyst commented 11 months ago

@coke Lets go with this patch for now. As more people use the site, we'll get some more feedback. There are probably some tweaks to get the smaller footprints to work better.

coke commented 11 months ago

@coke Lets go with this patch for now

Agreed