Closed donaldh closed 12 months ago
@coke looks fine to me. I'm not able to merge as on street market, so wifi skimpy
On Mon, 4 Dec 2023, 17:44 Will Coleda, @.***> wrote:
@.**** approved this pull request.
— Reply to this email directly, view it on GitHub https://github.com/Raku/doc-website/pull/324#pullrequestreview-1763036536, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACYZHF4B7GSFYMNJW2H7ODYHYDWVAVCNFSM6AAAAABAGKVAPGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONRTGAZTMNJTGY . You are receiving this because you were assigned.Message ID: @.***>
Thanks for the PR!
Although I have agreed to the PR changing the original order, and I agree Class and Role are more informative, some users prefer Composite first. Just documenting this here.
Also the search config options (button on right of search input) allow for turning off and on Composite Heading etc
On Mon, 4 Dec 2023, 17:19 Donald Hunter, @.***> wrote:
The order of sections in search results was:
- Language
- Composite
- Class
- Role ...
Change the sort order to move Composite down below Class and Role because they both provide more relevant results.
You can view, comment on, or merge this pull request online at:
https://github.com/Raku/doc-website/pull/324 Commit Summary
- a6a851d https://github.com/Raku/doc-website/pull/324/commits/a6a851d8933f3407664f013b3e8c5d263c9c586d Move Composite below Class and Role in search results
File Changes
(1 file https://github.com/Raku/doc-website/pull/324/files)
- M Website/plugins/options-search/add-options-search.raku https://github.com/Raku/doc-website/pull/324/files#diff-9a69e8091c19c313efb12872fdc3c710fa7d76b21379c341f078ed364a0f6dd7 (6)
Patch Links:
- https://github.com/Raku/doc-website/pull/324.patch
- https://github.com/Raku/doc-website/pull/324.diff
— Reply to this email directly, view it on GitHub https://github.com/Raku/doc-website/pull/324, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACYZHGSCUM4CKM5AWD3Q33YHYAZPAVCNFSM6AAAAABAGKVAPGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZDIMZVGEYTKMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>
The order of sections in search results was:
Change the sort order to move Composite down below Class and Role because they both provide more relevant results.