search

Raku / doc-website

Tooling to build/run the documentation website
Artistic License 2.0
7 stars 10 forks source link

Miscellaneous page lacks editable tag. #338

Closed 0rir closed 7 months ago

0rir commented 8 months ago

/miscellaneous lacks the crayon that allows easier pull requests.

coke commented 8 months ago

This is a generated page, the edit tag is only for pages with direct source edits.

Might be a good idea to have the edit icon everywhere and have a pop that explains on the pages that cannot be directly edited.

finanalyst commented 7 months ago

@0rir @coke tl;dr is it worth putting a link to editable pages? Generated pages get a popup. Detail: There are currently 2 sorts of pages that do not get the edit crayon:

  1. Composite pages, which are composed of segments from the Primary pages (those in the Raku/docs/ repo)
  2. Structure pages, which are in this repo. The Miscellaneous page falls into this group.

Structure pages can be edited, via a PR on this repo, so we could set things up to allow for edits.

Composite pages cannot be edited because they are generated programmatically. So a pop-up is reasonable.

I'll create a PR to generate the pop-up. But I think we could support editing of the structure pages. Thoughts?

finanalyst commented 7 months ago

@coke @0rir please check out how this patch works on new-raku, eg miscellaneous. Also try a composite page by using search and choosing some page.

0rir commented 7 months ago

@finanalyst, Looks good. FYI my response time regularly can be out to a week.