search

Raku / docker

Docker files for Rakudo Star
Artistic License 2.0
34 stars 22 forks source link

Update Rakudo Star version to 2019.03 #24

Closed jstuder-gh closed 5 years ago

jstuder-gh commented 5 years ago

This updates the Rakudo Star version to 2019.03 from 2018.10.

The maintainer for Rakudo Star changed between 2018.10 and 2019.03 so the existing fingerprint used to retrieve the key and verify the tarball is not valid for the new release. Updating to include the new fingerprint along with the previous one; the old one will be used if the user sets the "rakudo_version" arg to a release prior to 2019.03 when building.

See Github Issue #23

tianon commented 5 years ago

It should be pretty safe to just do --recv-keys on both keys instead (separately); the unused key shouldn't cause any problems.

hoelzro commented 5 years ago

I agree with @tianon on the two keys thing, but other than that LGTM

jstuder-gh commented 5 years ago

Yeah two keys is a much better approach. I've pushed a new commit that does just that.

jstuder-gh commented 5 years ago

@hoelzro so now that the two key branching logic is removed, any objection to me merging this in and submitting to docker-official?

hoelzro commented 5 years ago

Go for it!