use -m option of useradd + add github action to test build

Raku / docker

Docker files for Rakudo Star

Artistic License 2.0

34 stars 22 forks source link

use -m option of useradd + add github action to test build #42

Closed sthiriet closed 3 years ago

sthiriet commented 3 years ago

fix my previous PR

sorairolake commented 3 years ago

I think using -m option in useradd will create a home directory (as described in the man page). In this case, I think that the code added in #41 (mkdir and chown) will be unneeded.

sthiriet commented 3 years ago

@sorairolake : 👍 @JJ : I will try to use -m + init a github action that test the built image

sthiriet commented 3 years ago

In github workflow, in order to dynamically test all build without changing the action, I assume that the directory tree will remain <Version>/<BaseImages>/Dockerfile

After the build step, i have added two tests, one with root and one with raku user that run a zef command that list installed module and a raku command that print raku version. (the zef command failed with raku user before fixing the user directory creation). Probably there are more tests to add?

You can see the result here : https://github.com/sthiriet/docker/actions

jmaslak commented 3 years ago

@JJ - do you have a way of testing PRs yet? This PR likely fixes a Dockerfile error that prevents building of the Buster image, so I'd like to see it submitted (but I don't know anything about github actions so I can't comment on that part of the PR). I'd also like to submit a couple PRs to modernize the versions of Alpine and Rakudo-Star in Docker Hub.