search

Raku / examples

Many examples of Raku code
https://examples.raku.org/
Artistic License 2.0
297 stars 82 forks source link

correct tests to be compatible with rakudo 2016.04 #43

Closed tbrowder closed 8 years ago

tbrowder commented 8 years ago

All tests passed on Deb 8, 64-bit, rakudo 2016.04.

.travis.yaml changed to use latest rakudo.

paultcochrane commented 8 years ago

Hi Tom. Thanks for the patches! Great to have some attention being made on this repo :-)

Could you look at the issues I mention in the patches and resubmit? Also, would it be possible to squash the merge commit so that it doesn't appear in the PR?

tbrowder commented 8 years ago

On Monday, May 2, 2016, Paul Cochrane notifications@github.com wrote:

Hi Tom. Thanks for the patches! Great to have some attention being made on this repo :-)

You're welcome, Paul.

Could you look at the issues I mention in the patches and resubmit?

WILCO

BTW, the unneeded module may have come from one of the many tests that have been held back--I did not look at those at all.

Also, would it be possible to squash the merge commit so that it doesn't appear in the PR?

I will be happy to if someone could tell me how to do it--my knowledge of git is minimal!

Best regards,

-Tom

tbrowder commented 8 years ago

I'm having trouble with the dependency check for module "Web" which is the project name by which panda knows it and the actual use statement for testing which looks like it has to be "use Web::Respect." I'm going to try zef to see if there are any better results.

paultcochrane commented 8 years ago

A git grep 'Web::Request' showed up that the module is used in categories/cookbook/19cgi-programming/19-01cgi-script.pl.

For some reason panda couldn't find Web in the ecosystem, however a panda update fixed that; running panda install Web after the update installed the module successfully. Hence I'd like to leave the dependency in the Makefile and the dependencies check test.

BTW: by using git pull --rebase one can to avoid merge commits; hope that helps a bit with avoiding merge commits such as appeared in this PR.

zoffixznet commented 8 years ago

For some reason panda couldn't find Web in the ecosystem

FWIW, it's because the author renamed the META file but not the Ecosystem URL for it. It got fixed yesterday: https://github.com/perl6/ecosystem/commit/8b7824d57c4416d22dcdb8c44a9aa09cfa92bdcb

tbrowder commented 8 years ago

I made more corrections so the tests should work now--awaiting (and anticipating) a successful build!

tbrowder commented 8 years ago

Successful build--ready for merge.