search

Raku / old-issue-tracker

Tickets from RT
https://github.com/Raku/old-issue-tracker/issues
2 stars 1 forks source link

Potential issue with `is default` and Promises #6621

Open p6rt opened 7 years ago

p6rt commented 7 years ago

Migrated from rt.perl.org#132326 (status was 'new')

Searchable as RT132326$

p6rt commented 7 years ago

From @zoffixznet

Today we had to revert an `is default` use in Promise.pm​: https://github.com/rakudo/rakudo/commit/d20e972a12

The commit caused a reproducible hang in S17-promise/lock-async-stress.t and S17-promise/lock-async-stress2.t tests while running stresstests, although when running the test files on their own, they passed (each takes ~50s to run)

It's possible there's some issue in `is default` that occurs under stress.

IRC​: https://irclog.perlgeek.de/perl6-dev/2017-10-20#i_15330009

p6rt commented 7 years ago

From @zoffixznet

https://irclog.perlgeek.de/perl6-dev/2017-10-20#i_15330070

13​:29 jnthn It'll probably be lazy attribute initialization 13​:30 lizmat jnthn​: but "is default" init isn't lazy ? 13​:30 is it? 13​:31 hmmm 13​:31 jnthn Attribute scalar container creation is 13​:31 Down in The Guts 13​:31 But I'd like to kill that off 13​:31 It makes every attribute access more expensive 13​:32 lizmat so how would you like to fix that ? 13​:32 jnthn I don't know yet.