something is wrong with gen_parrot.pl

p6rt commented 15 years ago

Migrated from rt.perl.org#64712 (status was 'resolved')

Searchable as RT64712$

p6rt commented 15 years ago

From sammydc@gmail.com

Hi,

I think this line is wrong: line 47: system(qw(svn checkout -r), $required , qw( https://svn.parrot.org/parrot/trunk parrot));

all qw should be removed, in my ubuntu, i think what' s happening is it's removing all the spaces, so I'm getting a bunch of error messages, i think this is better: system("svn checkout -r" . $required . " " . " https://svn.parrot.org/parrot/trunk parrot");

Regards, Sam

p6rt commented 15 years ago

From @coke

On Tue Apr 14 01:44:39 2009, sammydc@gmail.com wrote:

Hi,

I think this line is wrong: line 47: system(qw(svn checkout -r), $required , qw( https://svn.parrot.org/parrot/trunk parrot));

all qw should be removed, in my ubuntu, i think what' s happening is it's removing all the spaces, so I'm getting a bunch of error messages, i think this is better: system("svn checkout -r" . $required . " " . " https://svn.parrot.org/parrot/trunk parrot");

Regards, Sam

Out of curiosity, what error messages are you getting?

BTW, this command looks right to me, passing a list to system() instead of a string avoids shell escaping issues.

-- Will "Coke" Coleda

p6rt commented 15 years ago

The RT System itself - Status changed from 'new' to 'open'

p6rt commented 15 years ago

From john@perlwolf.com

On Tue, Apr 14, 2009 at 05:17:08AM -0700, Will Coleda via RT wrote:

On Tue Apr 14 01:44:39 2009, sammydc@gmail.com wrote:

Hi,

I think this line is wrong: line 47: system(qw(svn checkout -r), $required , qw( https://svn.parrot.org/parrot/trunk parrot));

all qw should be removed, in my ubuntu, i think what' s happening is it's removing all the spaces, so I'm getting a bunch of error messages, i think this is better: system("svn checkout -r" . $required . " " . " https://svn.parrot.org/parrot/trunk parrot");

Regards, Sam

Out of curiosity, what error messages are you getting?

BTW, this command looks right to me, passing a list to system() instead of a string avoids shell escaping issues.

The original looks right to me too, as long as $required contains a single file name and not a blank separated list. (But that would get treated instead as a single file name that had embedded blanks, which is the opposite symptom to the original description.)

p6rt commented 15 years ago

From sammydc@gmail.com

Hi Will,

Thanks for the reply. Here's the error message I'm getting:

Generating Parrot ... /usr/bin/perl build/gen_parrot.pl

via svn...t Parrot r37980 'vn: Syntax error in revision argument '37980

And I just tried it again, after changing line 47 to:

system("svn checkout -r" . $required . " https://svn.parrot.org/parrot/trunkparrot");

I was able to do a checkout of parrot.

Btw, my machine is running Ubuntu, Intrepid Ibex.

Regards, Sam

On Tue, Apr 14, 2009 at 5:17 AM, Will Coleda via RT \< perl6-bugs-followup@perl.org> wrote:

On Tue Apr 14 01:44:39 2009, sammydc@gmail.com wrote:

Hi,

I think this line is wrong: line 47: system(qw(svn checkout -r), $required , qw( https://svn.parrot.org/parrot/trunk parrot));

all qw should be removed, in my ubuntu, i think what' s happening is it's removing all the spaces, so I'm getting a bunch of error messages, i think this is better: system("svn checkout -r" . $required . " " . " https://svn.parrot.org/parrot/trunk parrot");

Regards, Sam

Out of curiosity, what error messages are you getting?

BTW, this command looks right to me, passing a list to system() instead of a string avoids shell escaping issues.

-- Will "Coke" Coleda

p6rt commented 15 years ago

From @markjreed

Please do not replace system(LIST) with system(STR). All sorts of complexities arise.

What is the exact value of $required? Is something maybe adding quotation marks to it? That would fit the symptom.

On 4/14/09, Sam Dela Cruz \sammydc@gmail\.com wrote:

Hi Will,

Thanks for the reply. Here's the error message I'm getting:

Generating Parrot ... /usr/bin/perl build/gen_parrot.pl

via svn...t Parrot r37980 'vn: Syntax error in revision argument '37980

And I just tried it again, after changing line 47 to:

system("svn checkout -r" . $required . " https://svn.parrot.org/parrot/trunkparrot");

I was able to do a checkout of parrot.

Btw, my machine is running Ubuntu, Intrepid Ibex.

Regards, Sam

On Tue, Apr 14, 2009 at 5:17 AM, Will Coleda via RT \< perl6-bugs-followup@perl.org> wrote:

On Tue Apr 14 01:44:39 2009, sammydc@gmail.com wrote:

Hi,

I think this line is wrong: line 47: system(qw(svn checkout -r), $required , qw( https://svn.parrot.org/parrot/trunk parrot));

all qw should be removed, in my ubuntu, i think what' s happening is it's removing all the spaces, so I'm getting a bunch of error messages, i think this is better: system("svn checkout -r" . $required . " " . " https://svn.parrot.org/parrot/trunk parrot");

Regards, Sam

Out of curiosity, what error messages are you getting?

BTW, this command looks right to me, passing a list to system() instead of a string avoids shell escaping issues.

-- Will "Coke" Coleda

-- Sent from my mobile device

Mark J. Reed \markjreed@gmail\.com

p6rt commented 15 years ago

From sammydc@gmail.com

Hi, I tried installing rakudo again just a minute ago, following this: http://rakudo.org/how-to-get-rakudo. It works ok now. Thanks guys!

Regards, Sam

On Tue, Apr 14, 2009 at 4:05 PM, Mark J. Reed \markjreed@gmail\.com wrote:

Please do not replace system(LIST) with system(STR). All sorts of complexities arise.

What is the exact value of $required? Is something maybe adding quotation marks to it? That would fit the symptom.

On 4/14/09, Sam Dela Cruz \sammydc@gmail\.com wrote:

Hi Will,

Thanks for the reply. Here's the error message I'm getting:

Generating Parrot ... /usr/bin/perl build/gen_parrot.pl

via svn...t Parrot r37980 'vn: Syntax error in revision argument '37980

And I just tried it again, after changing line 47 to:

system("svn checkout -r" . $required . " https://svn.parrot.org/parrot/trunkparrot");

I was able to do a checkout of parrot.

Btw, my machine is running Ubuntu, Intrepid Ibex.

Regards, Sam

On Tue, Apr 14, 2009 at 5:17 AM, Will Coleda via RT \< perl6-bugs-followup@perl.org> wrote:

On Tue Apr 14 01:44:39 2009, sammydc@gmail.com wrote:

Hi,

I think this line is wrong: line 47: system(qw(svn checkout -r), $required , qw( https://svn.parrot.org/parrot/trunk parrot));

all qw should be removed, in my ubuntu, i think what' s happening is it's removing all the spaces, so I'm getting a bunch of error messages, i think this is better: system("svn checkout -r" . $required . " " . " https://svn.parrot.org/parrot/trunk parrot");

Regards, Sam

Out of curiosity, what error messages are you getting?

BTW, this command looks right to me, passing a list to system() instead of a string avoids shell escaping issues.

-- Will "Coke" Coleda

-- Sent from my mobile device

Mark J. Reed \markjreed@gmail\.com

p6rt commented 15 years ago

From @coke

On Wed Apr 15 04:37:21 2009, sammydc@gmail.com wrote:

Hi, I tried installing rakudo again just a minute ago, following this: http://rakudo.org/how-to-get-rakudo. It works ok now. Thanks guys!

Regards, Sam

Good luck. =-)

Resolving ticket.

-- Will "Coke" Coleda

p6rt commented 15 years ago

@coke - Status changed from 'open' to 'resolved'

Raku / old-issue-tracker