search

Raku / problem-solving

🦋 Problem Solving, a repo for handling problems that require review, deliberation and possibly debate
Artistic License 2.0
70 stars 16 forks source link

Expmod returns a default value instead of erroring out on libtommath errors #150

Open MasterDuke17 opened 4 years ago

MasterDuke17 commented 4 years ago

15:49 | MasterDuke | so in roast we have tests for expmod that would that throw an exception if we were catching errors in libtommath 15:50 | MasterDuke | https://github.com/perl6/roast/blob/master/S32-num/expmod.t#L25-L37 15:51 | MasterDuke | the intent is to test that it doesn't hang, but the value we're testing for (0) is just because we don't catch the error and return a default value which ends up being 0 15:54 | MasterDuke | is it valid to just change the tests to dies-ok? 15:55 | MasterDuke | or should we try to keep behavior the same for Raku 6.c-d and change it only for Raku 6.e?

MasterDuke17 commented 4 years ago

https://github.com/Raku/old-issue-tracker/issues/6053 for some reference as to why those tests were added

MasterDuke17 commented 4 years ago

NQP tests fixed in https://github.com/perl6/nqp/commit/c7f4dfe9e1