Closed patrickbkr closed 3 years ago
It feels to me that the section is better be visually separated from the rest of the page. Perhaps enclosed into own "window"? Feel free to ignore my opinion if disagree. :)
LGTM
On Thu, Mar 11, 2021, 5:32 AM Vadim Belman @.***> wrote:
It feels to me that the section is better be visually separated from the rest of the page. Perhaps enclosed into own "window"? Feel free to ignore my opinion if disagree. :)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Raku/raku.org/pull/160#issuecomment-796304778, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUUHQHZQCSE7NC6DNKTA3TC73AFANCNFSM4Y6ZQLVQ .
Here is a version with a block around. Please give a :thumbsup: if you like this version better and a :thumbsdown: if you like the original version in the first comment better.
@wtwt5237 @scmorrison @jnthn @niner @zaucker @p6steve You didn't yet provide any feedback yet. As all of you were gave their initial approval over on the issue, I'll just leave this open a few more days and then assume silent approval and move forward with this should no objections arise.
@patrickbkr, I approve. This looks great! Thanks so much for the effort!
I approve
~ Steve Roe
@.***
On 23 Mar 2021, at 19:22, niner @.***> wrote:
@niner approved this pull request.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
I approve. Looks great.
It seems I can't add people as reviewers that are not somehow part of the GitHub project. So I'm pinging the bunch I can't add as reviewers.
@wtwt5237 @scmorrison @vedang Please review.
Fixes #155