search

Raku / roast

🦋 Raku test suite
https://raku.org/
Artistic License 2.0
180 stars 135 forks source link

Remove rosettacode tests #651

Closed coke closed 1 year ago

coke commented 4 years ago

These were added pre-6.c as a way to ensure that changes to Raku didn't break the examples on rosettacode - but this isn't the right repository for that sort of test. Only 2 tests were ever added anyway.

They got grandfathered into the spec in the Christmas release of 2015

t/spec/rosettacode/greatest_element_of_a_list.t ................... ok
t/spec/rosettacode/sierpinski_triangle.t .......................... ok
vrurg commented 4 years ago

What harm does it do to have them in there? The general idea of not breaking the examples published at one of the greatest sources of code snippets appeals to me as a good one.

And if not in roast where then? Though quick thinking brings an idea of a dedicated module which would be tested with Blin once in a while.

coke commented 4 years ago

Harm? If it's not spec, it doesn't belong.

Not breaking the examples is a good goal, but it's not the goal of roast.

Ingy had some work in this direction (https://github.com/ingydotnet/rosettacode-pm).

thundergnat commented 4 years ago

I don't have a horse in this race, it doesn't much matter to me if the existing Rosettacode tests stay in roast or not. I can see the argument either way.

Just as a point of reference, github user SqrtNegInf (not me) does a daily test run of the entire[*] Rosettacode Raku corpus on a current build of master. See: https://github.com/SqrtNegInf/Rosettacode-Perl6-Smoke

It isn't under direct community control, but he is pretty proactive about finding and reporting bugs that appear, so removing the tests from roast won't mean it doesn't get tested.

[*] ok, entire may be a stretch... more like about 90-95%; everything that can be run hands off and programmatically compared to expected output.

vrurg commented 4 years ago

@thundergnat Thanks for pointing at @SqrtNegInf project. I asked if he can turn his project into a testable module we can then test with Blin.