search

Raku / whateverable

🤖 Different IRC bots that operate on a bunch of prebuilt Rakudo versions
https://gist.github.com/Whateverable
GNU Affero General Public License v3.0
18 stars 14 forks source link

Eval stuff securely #25

Open AlexDaniel opened 7 years ago

AlexDaniel commented 7 years ago

This is going to be easy once the work on #23 is finished.

MasterDuke17 commented 7 years ago

This could also solve the problem we've been having recently where a bot dies and leave the rakudo directory for the commit it was currently using lying around. This blocks any other bots from running with that commit. This is particularly problematic because a high percentage of the bot invocations use HEAD, so if the bot dies it could essentially prevent most use of the other bots.

MasterDuke17 commented 7 years ago

A short term solution would be to add the name of the bot to the path it extracts into, then at least if it dies it won't block the other bots.

AlexDaniel commented 7 years ago

A short term solution would be to add the name of the bot to the path it extracts into, then at least if it dies it won't block the other bots.

That would mean building rakudo three times for each commit…

MasterDuke17 commented 7 years ago

Ugh, right, forgot that paths are hard-coded when it's built.

AlexDaniel commented 6 years ago

To resolve this fully we'd need to set SystemCallFilter and some other things also. It will always be a balance between tightening the nuts and letting people run stuff freely, but right now we're a bit too forgiving.