search

Raku / whateverable

🤖 Different IRC bots that operate on a bunch of prebuilt Rakudo versions
https://gist.github.com/Whateverable
GNU Affero General Public License v3.0
18 stars 14 forks source link

Fix syntax for blockers message. #343

Closed MorayJ closed 5 years ago

MorayJ commented 5 years ago

Checks if @tickets is empty and specifically reports 'no known blockers'.

I'm afraid that I couldn't test as couldn't install IRC::Client, but syntax seems ok.

Releasable says “at least 0 blockers” #333

AlexDaniel commented 5 years ago

It indeed doesn't matter, but can you try git commit --amend? Basically, --amend allows you to change the last commit. This means that you can add more files or do modifications, but you can also change the author field. For example:

git commit --amend --author="Philip J Fry <someone@example.com>"

Important thing here is that you don't need to close your PR or start a new one. Just git push --force your modified commit (don't do that to main repos, but for forks and PRs this is totally OK), and the changes will be visible in your PR.

It's just a useful thing to practice I think, give it a try maybe. Otherwise I see no problem merging.

MorayJ commented 5 years ago

Thanks for that...definitely worth practising and hopefully all worked out now!

AlexDaniel commented 5 years ago

Cool, thanks!

For what it's worth, the committer field remained unset. If you do this:

git log --pretty=full

It shows both author and committer. Normally both are set to the same value, but sometimes author and committer are different people. In this case:

Author: Moray Jones <git@(… …).co.uk>
Commit: = <=>

Also, your email is not yet associated with github (so it does not link to your profile still). Perhaps consider adding an alternate email to your github account (https://github.com/settings/emails).

MorayJ commented 5 years ago

Oh, right, thanks for that. Didn't realise there was a separate contributors things going on. I'll add the email address now to link this, though I realise it's actually not the one I meant to use!