Rakuten-Advertising-Developers / Affiliate-for-Server-Side-GTM

Apache License 2.0
1 stars 2 forks source link

Add support of Server logging standard #3

Open Bukashk0zzz opened 1 year ago

Bukashk0zzz commented 1 year ago

Hi,

What do you think about adding standardized logs to this tag? Currently, all popular tags support this standard which allows debugging more easier. If this is ok for you we can prepare PR for you.

https://github.com/stape-io/gtm-standards/blob/main/standards/GTMS-3.md

invi2000 commented 1 year ago

Hi @Bukashk0zzz , Thanks for your suggestion. Standards are always good. How adopted is your standard? But feel free to make a suggestion and we can review.

Bukashk0zzz commented 1 year ago

@invi2000 we prepared PR that add Logging standard. Please review when you will have time.

invi2000 commented 10 months ago

Hi @Bukashk0zzz , Thanks for the pull request. After internal discussion, we didn't follow your proposed mechanism because it doesn't add value to our advertisers and us when debugging and troubleshooting. We added more logToConsole calls to the code with specific information which is helpful for our teams and advertisers when debugging the template. We also don't want to further complicate the template config UI as we don't see a need for it. The debug output will only be shown when tag preview mode is enabled anyway.

Bukashk0zzz commented 9 months ago

The debug output will only be shown when tag preview mode is enabled anyway.

I think this is a key misunderstanding. Logs can be written in all modes. That's why we need to have a way to parse them in a standard way.

Example: You need to debug how many times your template tracked conversion and with which parameters in production. Basically, the Rakuten team often asks us to provide such info in case of any issues.

At this point, there is no way to do it with your template. If you support the Stape logging standard, then customers will be able to filter logs of sGTM easily, see only logs of your template, and understand the issue.