search

Raldir / FEVEROUS

Repository for Fact Extraction and VERification Over Unstructured and Structured information (FEVEROUS), accepted to NeurIPS 2021 Dataset and Benchmarks and used for the FEVER Workshop Shared Task at EMNLP2021.
Apache License 2.0
67 stars 20 forks source link

KeyError on missing ID #13

Closed creisle closed 3 years ago

creisle commented 3 years ago

When I run the steps in the README I get an error in one of the downstream steps due to missing an ID field. I did a basic grep through the code and found a commented out line that sets this. I re-added it and was able to run without issues subsequently.

https://github.com/Raldir/FEVEROUS/blob/bfbd67460bba9b4ff12c9901d76b70e34aaf1501/src/baseline/retriever/document_entity_tfidf_ir.py#L37

I think this needs to be uncommented?

Raldir commented 3 years ago

Thank you for pointing that out! Do you remember which downstream step was affected by it? Was it combine_retrieval.py? As the ids are not needed (and not part of the blind test set) the pipeline should run without them.

creisle commented 3 years ago

here's the traceback. It was in the combine_retrieval.py script

Traceback (most recent call last):
  File "src/baseline/retriever/combine_retrieval.py", line 29, in <module>
    sentences_pred[js['id']] = js['predicted_sentences']
KeyError: 'id'
Raldir commented 3 years ago

Should be fixed now!

creisle commented 3 years ago

Can confirm I no longer see this error. Thanks!