search

RalfG / python-wheels-manylinux-build

GitHub Action to build Python manylinux wheels
https://github.com/marketplace/actions/python-wheels-manylinux-build
Apache License 2.0
92 stars 44 forks source link

Allow specifying output directory #13

Closed CaselIT closed 4 years ago

CaselIT commented 4 years ago

Currently the wheels are placed in the wheelhouse folder, instead of the standard dist.

I think it would be nice to have a input to specify the destination folder. The default can remain wheelhouse

RalfG commented 4 years ago

I actually thought of changing the default to dist in a future version, as it makes more sense. For some reason wheelhouse is used in the manylinux container example script.

But an input for the destination folder is a good idea!

mrmundt commented 4 years ago

I would second this opinion!

A thought on this: You already have an option for users to utilize pip-wheel-args in the action. Why not remove the -w /github/workspace/wheelhouse/ assumption? Or allow for an override there?

RalfG commented 4 years ago

@mrmundt: I fully agree! I'll make this an option in the next version.