search

RalfG / python-wheels-manylinux-build

GitHub Action to build Python manylinux wheels
https://github.com/marketplace/actions/python-wheels-manylinux-build
Apache License 2.0
92 stars 44 forks source link

Add custom manylinux container #39

Closed ibell closed 2 years ago

ibell commented 3 years ago

I need a very brand spanking new version of clang to build my package (the current manylinux image doesn't cut it). So I made a manylinux container at https://hub.docker.com/r/ibellbelli/manylinuxclang with the new clang stuff, and I tried to add that to my call of this action, but it didn't work. I'm not sure if it ever can work with a truly custom docker image, but I'd like it to.

My failing example:

name: pypi deployer
on:
  push:
    tags:
      - "v*" # Push events to matching v*, i.e. v1.0, v20.15.10
jobs:
  Linux-build:
    runs-on: ubuntu-latest
    env:
      TWINE_USERNAME: ${{ secrets.TWINE_USERNAME }}
      TWINE_PASSWORD: ${{ secrets.TWINE_PASSWORD }}
      CXX: clang++
    steps:
      - uses: actions/checkout@v2
      - name: checkout submodules
        run: git submodule update --init --recursive
      - name: build and upload manylinux wheels
        uses: RalfG/python-wheels-manylinux-build@v0.3.4-ibellbelli/manylinuxclang
        with:
          python-versions: 'cp37-cp37m cp38-cp38m cp39-cp39m'
          build-requirements: 'cython numpy'
          pip-wheel-args: '-w ./dist --no-deps'

but no dice:

Getting action download info
Failed to resolve action download info. Error: Unable to resolve action `RalfG/python-wheels-manylinux-build@v0.3.4-ibell***%2Fmanylinuxclang`, unable to find version `v0.3.4-ibell***/manylinuxclang`
Retrying in 20.194 seconds
Failed to resolve action download info. Error: Unable to resolve action `RalfG/python-wheels-manylinux-build@v0.3.4-ibell***%2Fmanylinuxclang`, unable to find version `v0.3.4-ibell***/manylinuxclang`
Retrying in 17.82 seconds
Error: Unable to resolve action `RalfG/python-wheels-manylinux-build@v0.3.4-ibell***%2Fmanylinuxclang`, unable to find version `v0.3.4-ibell***/manylinuxclang`
RalfG commented 3 years ago

Hi @ibell,

For custom images, I would recommend to fork the repository and change the image name in Dockerfile: https://github.com/RalfG/python-wheels-manylinux-build/blob/04384c17f839cf45d096da094f8f8b0ca5017f1e/Dockerfile#L1

Then, create a new custom release on your repository, for instance called v0.3.4-ibellbelli/manylinuxclang. Then the action should work with the following name:

[...]
      - name: build and upload manylinux wheels
        uses: ibell/python-wheels-manylinux-build@v0.3.4-ibellbelli/manylinuxclang
[...]