search

RalfJung / cargo-careful

Execute Rust code carefully, with extra checking along the way
Apache License 2.0
382 stars 14 forks source link

Add an actions to deploy binaries automatically #16

Closed Luni-4 closed 1 year ago

Luni-4 commented 1 year ago

This PR adds an action to deploy binaries automatically and it fixes #12

RalfJung commented 1 year ago

Thanks for the PR!

That's a lot of stuff I don't know much about, I'll have to figure out how to best review this. Are these binaries created by cargo build really portable enough to be suited for binary releases?

Luni-4 commented 1 year ago

Thanks for the PR!

That's a lot of stuff I don't know much about, I'll have to figure out how to best review this. Are these binaries created by cargo build really portable enough to be suited for binary releases?

Thanks for your review!

I've mainly created these binaries for CI, to reduce cargo-careful's installing time, I don't know if they are suited for binary releases, I suppose they could be used for that purpose too, but not sure about that

RalfJung commented 1 year ago

I've mainly created these binaries for CI,

So after we land this, could you test whether they actually work on all 3 targets?

Luni-4 commented 1 year ago

I've mainly created these binaries for CI,

So after we land this, could you test whether they actually work on all 3 targets?

Sure! I'm going to report that here, but let's see if it works the deployment task first :)

Luni-4 commented 1 year ago

@RalfJung Can we land this PR or do I need to make some other changes?

RalfJung commented 1 year ago

Currently it is waiting for me to have time for review. I do this in my spare time and there are other PRs before this one in my queue. I will get to it eventually :)

RalfJung commented 1 year ago

Thanks! I have tweaked the code a bit, should be good to go now. And then I guess I should test whether it works. :)

Luni-4 commented 1 year ago

Sorry @RalfJung I hadn't had time to test the last changes, I thought they would have been pretty straightforward looking at other examples around. Since I hadn't provided any example to demonstrate the functionality of this script, I didn't think my changes would have been immediately used for a seriuous release.