search

Ralim / IronOS-Meta

Storing meta information about devices that dont need to be in the main repo
54 stars 10 forks source link

Print size of frames #4

Closed Ralim closed 2 years ago

discip commented 2 years ago

@Ralim Sorry for nagging, but now there is on minor issue regarding the enumeration of the frames. Now it starts at frame 0 instead of frame 1.

Could you please change that to frame 1 again?

thanks in advance

Ralim commented 2 years ago

It always did, I just forgot to print frame 0 😅

discip commented 2 years ago

But frame 0 is somewhat surreal! 😁

So the -1 should be reverted I guess!

Ralim commented 2 years ago

I agree, guess it's my inner programmer to count from 0 😮

I'll update to fix the counting to be friendly with frame 1,2,3 and so on

discip commented 2 years ago

@Ralim

I'll update to fix the counting to be friendly with frame 1,2,3 and so on

Already created a PR addressing that one.

One more thing: The sum being calculated adds 2 extra bytes compared to summing up the individual sizes by hand. Do the individual sizes get rounded up? Could you please have a look on that?