Ralim / IronOS

Open Source Soldering Iron firmware
https://ralim.github.io/IronOS/
GNU General Public License v3.0
7.28k stars 723 forks source link

Show power source type on detailed screen in soldering mode #1708

Closed ia closed 1 year ago

ia commented 1 year ago

Hello.

Rationale

Hence,

Proof-of-Concept

Here is how it could look:

Quick Charge Power Delivery Sleeping DbgMenu QC DbgMenu PD

Patch

In the next few minutes I'm going to make a pull request. But I create this feature request as issue report for documentation purposes in case if someone else will be looking for this feature searching through opened & closed issues.

Disclaimer

I'm sorry if I'm messing too deep with source tree by modifying essential core methods/functions. But I think that this feature fits perfectly for the detailed info screen option. A few notes:

As always, can't wait to hear any feedback. Wouldn't you want to see a power type right on the soldering screen?

Ralim commented 1 year ago

My feedback on this is fairly simple: 👍🏼 Looks good and makes sense. I dont use detailed view so I dont have a personal opinion on it aesthetically.

@discip or @River-Mochi May have stronger opinions 😁


On the code side, never feel bad if you reach into lots of code for a PR; thats what the PR is there for. If its too messy it's often a sign of needing some abstraction or cleanup.

Generally if the firmware builds it should run and work. Only risk is you somehow get heater stuck on, which will make tip get hot - fast. (and you can unplug if that happens). Otherwise you shouldn't be able to cause permanent damage.

ia commented 1 year ago