Closed ghost closed 3 years ago
Great effort and interesting request. I just want to say that I personally like the static pictures better, but of course depends on majority or repo owner ;)
Animated GIFs as a filetype won't work, but if you combine the frames for each animation to a sprite sheet, the animation can be done by drawing a part of the image at a time.
Also, is that supposed to be a Monkey Wrench or Calipers?
Because I've always thought that type of an icon is the wrench, but the animation (and well, calibration/calipers) makes me feel like I've been lied to my whole life.
@JohnEdwa I think its meant to be Calipers :smile:
I like this idea, there has also been calls for custom idle screens to be supported. I think both of these things are doable, however I would like to first :
Also I feel most people will want the icons to not animate to make them easier to see and less confusing if your eyesight is poor. Not too sure on that one though.
Also I feel most people will want the icons to not animate to make them easier to see and less confusing if your eyesight is poor. Not too sure on that one though.
Mmh, one thing that popped to my mind is that they should default to the full icon at the start. With the provided examples, the first few frames of the spanner and sleep animations are almost empty and very similar to each other.
@JohnEdwa I confirm, it's a vernier type caliper, at least in my intention! :smile: Here GIFs with full icon at the start: (←one time ones)
Designing icons was not too big of an effort; I'm open to modify styles as many times as needed (absolutely no problem). However, one-time-running icons would probably be a good compromise between static and animated ones.
At this point in time I'm not going to add animations purely because of flash space concerns showing up. I will hold this issue open so that hopefully this can be added later on :)
So, I added intermediate frames, and it will even look like animation, but I don't know how to implement it.
https://github.com/playday3008/IronOS/tree/animated-icons
and maybe important info, TS100_EN.hex
size 98 KB → 99 KB, I guess it's probably nothing
P.S. yep, time to write the code that was asked for 3 years ago
Hex file increasing is not as much of a concern; if we run out of flash space the CI will fail which will catch this. I believe TS80P is the device with the least flash at the moment.
Hex file increasing is not as much of a concern; if we run out of flash space the CI will fail which will catch this. I believe TS80P is the device with the least flash at the moment.
Then what's the problem?
Check if the changes work for TS80P. At the time this was shelved we had 0 spare flash space. Since then there was a lot of re-work of languages to increase the available flash space. My previous answer on this was from 2018 and as such is related to the state of things in 2018.
Well
TS80P_EN.hex
size 113 KB → 114 KB
What is the object size that is printed out? Hex size is extremely misleading Or the binary file size?
If you run the build all script do all languages for all 4 irons build ?
If you run the build all script do all languages for all 4 irons build ?
Yep
Or the binary file size?
TS80P_EN.bin
size 39.8 KB → 40.1 KB
gcc -Os
flag magic
I see no reason not to do it then
I see no reason not to do it then
So, I have frames, you have brain, lets go mb
I did it, but it needs to be improved
I'm submitting a ...
[x] Feature request
Do you want to request a feature or report a bug?
Insert GIFs instead of static images in the main menu (if possible)
Steps to reproduce:
Access main menu by pressing the nearest button to the micro-USB port
What are you running:
Other information
(one time run) (in perpetual running) (revisited better-looking PNGs)