search

Ralim / IronOS

Open Source Soldering Iron firmware
https://ralim.github.io/IronOS/
GNU General Public License v3.0
7.21k stars 713 forks source link

Problem with display polish "ł" letter. #728

Closed canislupus11 closed 3 years ago

canislupus11 commented 3 years ago

There is a problem with the display of the letter "ł" when using the Polish language version. Instead of "w" all you see is a blank space. Temporarily, for readability, in the translation corrections I have removed all the letters "ł" replacing them with "l". After fixing the bug, I will correct the translation.

Ralim commented 3 years ago

Hmm, interesting. All of the font data is generated from here: https://github.com/Ralim/ts100/blob/master/Translation%20Editor/fontTables.py And it looks like that symbol should be there :/

Ill have a look into this in a bit :)

KITT3000 commented 3 years ago

@Ralim The TS80 displays correctly, he has the TS100 and apparently that's the only problem there.

canislupus11 commented 3 years ago

on my TS100: https://imgur.com/a/JDPda7z

Ralim commented 3 years ago

@KITT3000 Its the same code for displaying characters for all systems. So TS80/TS100/TS80P/Pinecil all use the same font tables generated from the python code base.

@canislupus11 Are you using a local build of the firmware or the one from CI?

canislupus11 commented 3 years ago

@canislupus11 Are you using a local build of the firmware or the one from CI?

I using firmware version downloaded from github release...

KITT3000 commented 3 years ago

@Ralim I downloaded the current pre-release today and there is also a lack with this letter on the TS80. But the problem is only with the main text, the character is displayed correctly with the description, e.g. There is no letter here: https://github.com/Ralim/ts100/blob/master/Translation%20Editor/translation_pl.json#L181 and here is the letter displayed: https://github.com/Ralim/ts100/blob/master/Translation%20Editor/translation_pl.json#L184

Ralim commented 3 years ago

Interesting @KITT3000 Thank you for that, helps narrow down the issue.

Can you confirm for me what the difference between Ł and ł is; and if to you this issue is only present for one or the other? (Not entirely trusting my ability to pick the difference as most of my tooling is matching both)

KITT3000 commented 3 years ago

@Ralim Ł - capital letter (used in a word that begins a sentence or a word as a proper name) ł - lowercase letter

Ok, however it is used "Ł" in TS80, e.g. https://github.com/Ralim/ts100/blob/master/Translation%20Editor/translation_pl.json#L22 and there is a display problem

Ralim commented 3 years ago

This should be fixed now.

canislupus11 commented 3 years ago

This should be fixed now.

Seems to be OK. Thanks!