dash instead of values in 'Power pulse wait time' and in 'Power pulse duration'

[discip]

This is a [Bug Report]

• I have

  • [x] Searched previous issues
  • [x] This is in this firmware, not vendor "official" firmware
  • [x] This is not a bug in the vendor bootloader (aka DFU)
  • [x] I have checked, this is not already covered in the docs in /Documentation

• What is the current behavior? The only symbol shown as value of the newly implemented entries: Power pulse wait time and Power pulse duration is a dash.

• What is the expected behavior? The respective value should be represented, where now there is the dash.

• Is the issue reproducible. Yes

  • Steps to reproduce:
    1. Go to Advanced options.
    2. Now go to Power pulse wait time or Power pulse duration.
    3. Now you see the mentioned dash.

• What is the motivation / use case for changing the behavior? To help, making the iron function as it was intended to.

• What are you running: topic	TS80P
  Firmware Version	https://github.com/Ralim/IronOS/commit/ecf4651f6df5004fef1031cd23e54a385ff1ae24
  PCB Version	2

Thank you in advance kind regards

[Ralim]

Hmm, you should be able to adjust it from there; looks like dash is the "off" state.

I'll have a look when I can tonight though

[discip]

@Ralim Good evening sir, no it is not only the 'off state', since the value remains a dash no matter how often the A button is pressed, however the actual value seems to increase in the background, because at some point the 'scroll bar' starts to blink (For both entries the same!).

[Ralim]

I think what may have been occuring is that you were attempting to adjust the duration with the pulse power turned to off.

[discip]

@Ralim You are totally right about that! 🤦‍♂️ Nevertheless, I think, it would be much more convenient, to make these entries disappear, if Power pulse is turned off. regards

[Ralim]

I agree. Shall fix that tonight (reopening ticket)

[devydd]

I think what may have been occuring is that you were attempting to adjust the duration with the pulse power turned to off.

Yes, that was my intent. You have to enable power pulse before changing settings related to the power pulse.

And I agree it would be better to remove those two options altogether from the menu when the power pulse is off.

[Ralim]

@discip Can you give latest master a spin? I think that should handle it :)

[discip]

@Ralim That worked! 😃👍 Thank you!

[devydd]

Working as expected. Confirmed on TS80.