search

Ralith / openxrs

OpenXR bindings for Rust
Apache License 2.0
282 stars 59 forks source link

Remove `khr_vulkan_enable` support in example #115

Closed zmerp closed 2 years ago

zmerp commented 2 years ago

All major XR runtimes have upgraded to khr_vulkan_enable2 and new runtimes implement khr_vulkan_enable2 directly. This change makes the example more concise and straightforward. khr_vulkan_enable support is kept in openxrs API for legacy reasons.

kanerogers commented 2 years ago

Is this correct? The Oculus Quest (the first one) did not support enable2 last time I checked.

On Tue, 26 Apr 2022 at 2:45 am, Benjamin Saunders @.***> wrote:

Merged #115 https://github.com/Ralith/openxrs/pull/115 into master.

— Reply to this email directly, view it on GitHub https://github.com/Ralith/openxrs/pull/115#event-6492267464, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPNXZZKEOYO2MPN2RTYFQDVG3HJ7ANCNFSM5UITF6MA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Ralith commented 2 years ago

It'd be interesting to have confirmation, but if someone really needs to target that, they can always use an old release or the raw API. This being a volunteer project I have limited bandwidth to support hardware that even first-party support has been dropped for.

kanerogers commented 2 years ago

I've had a think about this, @Ralith and I think you're right. 👍🏻

We'll move to khr_vulkan_enable2 in Hotham and drop support for the Quest.

kanerogers commented 2 years ago

I’ve had a think about this and I’m inclined to agree.

The Quest 1 is old hardware and attempting to support it is probably beyond the scope of our limited resources, both Hotham and OpenXRs.

On Tue, 26 Apr 2022 at 8:29 am, Benjamin Saunders @.***> wrote:

It'd be interesting to have confirmation, but if someone really needs to target that, they can always use an old release or the raw API. This being a volunteer project I have limited bandwidth to support hardware that even first-party support has been dropped for.

— Reply to this email directly, view it on GitHub https://github.com/Ralith/openxrs/pull/115#issuecomment-1109104446, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPNXZ7NPM5T7KIJFS4UU2LVG4MGDANCNFSM5UITF6MA . You are receiving this because you commented.Message ID: @.***>