search

Ralith / openxrs

OpenXR bindings for Rust
Apache License 2.0
282 stars 59 forks source link

`next` parameter in `SessionCreateInfo` #144

Open yshui opened 1 year ago

yshui commented 1 year ago

The next is needed for passing, for example, XrSessionCreateInfoOverlayEXTX to create_session for extensions like XR_EXTX_overlay. Right now there is no way of setting it.

yshui commented 1 year ago

https://github.com/Ralith/openxrs/blob/8fd7155632dd8fb3caaf1a86be8b08c99da38f02/openxr/src/graphics/vulkan.rs#L51

Ralith commented 1 year ago

The intention is that, if you need something not expressed in the safe API, you invoke the raw function pointers yourself via e.g. Instance::fp. Contributions of safe bindings are welcome, but it might be a bit premature to do that for an EXTX extension.

yshui commented 1 year ago

but create_session is already unsafe API...

yeah i can do it with the sys crate, it's just inconvenient.

Ralith commented 1 year ago

but create_session is already unsafe API...

True, but I'd rather not make it even less safe.

yeah i can do it with the sys crate, it's just inconvenient.

It shouldn't require much more code.