search

Ralith / openxrs

OpenXR bindings for Rust
Apache License 2.0
282 stars 59 forks source link

Derives `Debug` for most sys structs #91

Closed ashpil closed 3 years ago

ashpil commented 3 years ago

This derives Debug for most sys structs, aiding in debugging.

There was some concern about whether this increases compilation time - I found only about a 5% increase in my benchmarks, making this PR so you can try yourself.

ashpil commented 3 years ago

Also noticed BitOrAssign for StructMeta doesn't update has_array - not sure if you specifically excluded certain fields from that, so I didn't add has_unprintable either.

Ralith commented 3 years ago

I think that was unintended; they should both be propagated, though I doubt this will change the output.

ashpil commented 3 years ago

@Ralith is there anything more this PR needs?

Ralith commented 3 years ago

Nope, thanks!