Closed kcking closed 2 years ago
Thanks, this is very welcome! For ease of review, could you reformat this PR as a series of minimal, atomic commits that each address a single thing?
Thanks for taking a look! I'm getting the commits tidied up and then will respond to your comments
Thank you for the super helpful comments! I believe I followed all of your suggestions.
I made all EventData constructors unsafe as you mentioned. I generated a doc comment to point the user toward the analagous struct in sys
which has a pointer to the openxr spec.
Also I added the Session::create_foveation_profile
impl in foveation_profile_fb.rs
instead of session.rs
since it seemed more relevant.
This latest commit should address both issues since they affected the same line :)
Ah I can fix those lints
Released in 0.15.5.
Released in 0.15.5.
🎉 thank you for all of the help with this!
The foveation profile bindings seem to be incomplete. You need also bindings for xrUpdateSwapchainFB
in XR_FB_swapchain_update_state
to be able to apply the foveation profile.
I took a crack at updating the generator for openxr 1.0.20. A couple things I found relatively general solutions to, and a couple I opted for a quick one-off change. Here's a list of things I changed
.
XR_SWAPCHAIN_USAGE_INPUT_ATTACHMENT_BIT_{MND,KHR}
XrViveTrackerPathsHTCX
Action
setter parameter which has genericActionTy
, akin toG: Graphics
type parameter_COUNT
and_SIZE_FB
length suffixesFoveationProfileFB
wrapper structLet me know if this type of contribution is desirable and if there's anything you'd like to be approached differently!