search

RallyTools / RallyRestToolkitForRuby

A toolkit wrapping Rally's REST webservice for Ruby
MIT License
47 stars 32 forks source link

Enforcing valid SSL certs #2

Closed Echo3ToEcho7 closed 12 years ago

Echo3ToEcho7 commented 12 years ago

Hi David,

While doing some tests for RAM on a test cluster I ran into an issue where the changes you made to 0.7.0 where the httpclient won't connect to a Rally instance that has an invalid SSL certificate. I have a patch where I set the verify_mode to VERIFY_NONE, but I don't think that we should just turn off ssl verification be default.

I added the following line to line 29 in rally_json_connection.rb: @rally_http_client.ssl_config.verify_mode = OpenSSL::SSL::VERIFY_NONE

Maybe this should be a config parameter or an environment variable. Not sure which and wanted your thoughts.

Cheers, Colin

dawsmith8 commented 12 years ago

Thanks Colin - yeah - I'll add a config option and default to none since that is what I had with RestClient in there. Good catch.

dawsmith8 commented 12 years ago

Added a method in 0.7.1