search

RalphAS / PeriodicSchurDecompositions.jl

Julia package for periodic Schur decompositions of matrix products
Other
8 stars 0 forks source link

failures with unit period #9

Closed rveltz closed 1 year ago

rveltz commented 1 year ago

Hi,

I think there is a corner case that is missing

partial_pschur([rand(100,100)+I],10) #errors
partial_pschur([rand(100,100)+I,rand(100,100)+I],10) #does not
RalphAS commented 1 year ago

Your case results (mainly?) from type instability of some generator expressions, which cause trouble for several functions in this package. (So I'm generalizing the issue title.) I'll try to be systematic about correcting for this (and adding tests).

rveltz commented 1 year ago

basically, I am using your package for shooting, hence I might as well need to have a single shooting. I dont want to call a different function depending on the number of shooting planes

RalphAS commented 1 year ago

That's reasonable. I have fixed (on a local branch) the crash-causing indexing and type issues for unit period, but some of the algorithms needed for Krylov-Schur are not yet working correctly for that case, so I'll keep working on it.

RalphAS commented 1 year ago

This issue should be fixed in v0.1.2