search

RalphTro / epcis-event-hash-generator

ALGORITHM and SOFTWARE PROTOTYPE to uniquely identify/validate the integrity of any EPCIS event through a common, syntax-agnostic approach based on hashing. Takes an EPCIS Document (formatted in either XML or JSON-LD) and returns the corresponding hash value(s).
MIT License
8 stars 4 forks source link

missing attributes #17

Closed Echsecutor closed 4 years ago

Echsecutor commented 4 years ago

e.g. type="urn:epcglobal:cbv:btt:desadv" is missing from https://github.com/RalphTro/epcis-event-hash-generator/blob/master/tests/examples/epcisDocWithVariousEventTypes.prehashes

Echsecutor commented 4 years ago

bizTransactionList was missing type in the ordering specs

Echsecutor commented 4 years ago

@RalphTro actually bizTransactionList appears in position 7 or 17 depending on the event type. Can we please make the ordering of fields independend of the event type? I.e. put the list in position 17, say, regardless of the type. (or 7, but make it unique, please).

RalphTro commented 4 years ago

Well...in this case, we would introduce an exception to our principle to stick to the EPCIS event data model. Unfortunately, for the TransactionEvent, it just appears at this position.

Echsecutor commented 4 years ago

actually the current algorithm has a bug and adds the list twice, which apparently went unrecognised so far. I have now moved it down to pos 17.