search

RalphTro / epcis-event-hash-generator

ALGORITHM and SOFTWARE PROTOTYPE to uniquely identify/validate the integrity of any EPCIS event through a common, syntax-agnostic approach based on hashing. Takes an EPCIS Document (formatted in either XML or JSON-LD) and returns the corresponding hash value(s).
MIT License
8 stars 4 forks source link

url namepsace deliminators in prehash #18

Closed Echsecutor closed 4 years ago

Echsecutor commented 4 years ago

Namespace URLs should be surroundeed by "{" and "}" instead of postfixed by "#" to avoid confusion with "#" appearing in URLs. @RalphTro What do you think?

RalphTro commented 4 years ago

Hi @Echsecutor, I like Mark's/your approach to work with sth. else than '#'. What is your reasoning to go for {} instead of what Mark suggested in his e-mail on this ("I'd suggest not using '#' but instead, either use an empty string or use a space character (space may not appear within a URI but is OK as a separator within data input to a hash function).")? Thanks in advance for sharing your thoughts!

Echsecutor commented 4 years ago

I am not a fan of white space. Emptystring is fine for me. the "{" "}" is the canonical XML way to denote the namespace, hencewe follow an existing "standard". ;)

RalphTro commented 4 years ago

As you have more experience in that, I am agreeable with any appropriate way...so, please go ahead! ;-)

Echsecutor commented 4 years ago

@RalphTro this means that the example with the picture in the README needs to be changed. Sorry.