RalphTro / epcis-event-hash-generator

ALGORITHM and SOFTWARE PROTOTYPE to uniquely identify/validate the integrity of any EPCIS event through a common, syntax-agnostic approach based on hashing. Takes an EPCIS Document (formatted in either XML or JSON-LD) and returns the corresponding hash value(s).
MIT License
8 stars 4 forks source link

Filter eventID in Hashing module, not in parsers #43

Closed Echsecutor closed 3 years ago

Echsecutor commented 3 years ago

In https://github.com/RalphTro/epcis-event-hash-generator/commit/9d47cd2721175b07ee112d5e01a3d8e3423f5eba the parsers where modified to remove the event ID directly after parsing the document.

Rational: Removing a field that is not an artefact of the data-format but part of the EPCIS data-model is not in the responsibility of the parsers. The Actual Hashing Algorithm that specifies the removal is implemented in it's own module.