search

RalphTro / epcis-event-hash-generator

ALGORITHM and SOFTWARE PROTOTYPE to uniquely identify/validate the integrity of any EPCIS event through a common, syntax-agnostic approach based on hashing. Takes an EPCIS Document (formatted in either XML or JSON-LD) and returns the corresponding hash value(s).
MIT License
8 stars 4 forks source link

Issue 31 dl normalisation #45

Closed Echsecutor closed 3 years ago

Echsecutor commented 3 years ago

Added Ralphs GS1 URI Normaliser to convert all matching uris to canonical digital link (DL) form

Echsecutor commented 3 years ago

@RalphTro could you check at least some of the prehashstrings changes in https://github.com/RalphTro/epcis-event-hash-generator/pull/45/commits/0099dc1b51281bb28d9f761bed097c307c8f7570 to verify that the normalisation works as expected?

I have converted your examples to tests/dl_normaliser_test.py maybe you could also have a look there if the URIs are properly converted.

RalphTro commented 3 years ago

Hi @Echsecutor , All IDs in 0099dc1 which I checked look good. Thanks a lot!

Did you already push the new file (tests/dl_normaliser_test.py)? Happy to have a look at them, too.

Echsecutor commented 3 years ago

@RalphTro :+1: thanks!