Do not parse back and forth

RalphTro / epcis-event-hash-generator

ALGORITHM and SOFTWARE PROTOTYPE to uniquely identify/validate the integrity of any EPCIS event through a common, syntax-agnostic approach based on hashing. Takes an EPCIS Document (formatted in either XML or JSON-LD) and returns the corresponding hash value(s).

MIT License

8 stars 4 forks source link

Do not parse back and forth #5

Closed Echsecutor closed 4 years ago

Echsecutor commented 4 years ago

Currently there is some back and forth between handling XML as a string in order to split and replace and using https://docs.python.org/3.5/library/xml.etree.elementtree.html to map to python objects and use utilities there.

Doing this mapping only once seems much preferable and will in particular resolve https://github.com/RalphTro/epcis-event-hash-generator/issues/3

Echsecutor commented 4 years ago

fixed in 12f49f5d0ba9d2df3bd05f98187558e4e22aa180 (https://github.com/RalphTro/epcis-event-hash-generator/pull/7)