persistentDisposition field

[clementh59]

Dear @RalphTro ,

The algorithm doesn't explain how to handle a persistentDisposition field (define here and implemented here for example).

Shall we consider it as a customField and add it at the end of the pre-hash string?

Regards,

Clément

[RalphTro]

Dear @clementh59 , 👍 you are a really good quality gate! You are correct. This is an oversight and needs to be added to the PROP_ORDER.

I see the following ToDos:

• Inclusion of persistentDisposition on https://github.com/RalphTro/epcis-event-hash-generator (after position 17, i.e. disposition - which makes most sense from my perspective)
• dto, in the CBV standard draft
• dto, in the code, e.g. https://github.com/RalphTro/epcis-event-hash-generator/blob/master/epcis_event_hash_generator/__init__.py
• provide example (xml + json.ld with persistentDisposition) + test

Will address this in the upcoming weeks.

Thanks a lot for pointing this out - very much appriated!

Kind regards, @RalphTro

[clementh59]

Dear @RalphTro ,

Thanks 😂.

Great, thanks. Yes, after position 17 makes sense.

Best regards, Clément

[RalphTro]

Dear @Echsecutor , I almost managed to address all activities necessary to address this issue, i.e.:

• changed the property order
• added examples with persistentDisposition (both in xml and jsonld as well as corresponding hash/prehash files)
• adjusted the documentation ...all in the branch https://github.com/RalphTro/epcis-event-hash-generator/tree/persistentDisposition

But :-) the only thing I do not understand why the algorithm returns e.g. disposition=https://ns.gs1.org/voc/Disp-in_transitreadPointid=https://id.gs1.org/414/4012345000054persistentDispositionset=https://ns.gs1.org/voc/Disp-recalled

while according to the specified (new) property order (https://github.com/RalphTro/epcis-event-hash-generator/blob/persistentDisposition/epcis_event_hash_generator/__init__.py), it SHOULD be: disposition=https://ns.gs1.org/voc/Disp-in_transitpersistentDispositionset=https://ns.gs1.org/voc/Disp-recalledreadPointid=https://id.gs1.org/414/4012345000054 (i.e. readPoint should appear after disposition/persistentDisposition)

Would you mind (as soon as your bandwidth allows for it!) to have a look into this so that the algorithm returns the correct pre hash string? Many thanks in advance; Ralph

[Echsecutor]

Sorry for not really monitoring my github messages! If you open a PR I am happy to review and fix the last bits

[Echsecutor]

fixed in https://github.com/RalphTro/epcis-event-hash-generator/pull/58 by @RalphTro . Many thanks!