Persistent disposition - Githubissues

RalphTro / epcis-event-hash-generator

ALGORITHM and SOFTWARE PROTOTYPE to uniquely identify/validate the integrity of any EPCIS event through a common, syntax-agnostic approach based on hashing. Takes an EPCIS Document (formatted in either XML or JSON-LD) and returns the corresponding hash value(s).

MIT License

8 stars 4 forks source link

Persistent disposition #58

Closed RalphTro closed 2 years ago

RalphTro commented 3 years ago

Dear @Echsecutor ,

As just discussed - issue https://github.com/RalphTro/epcis-event-hash-generator/issues/57 has not been addressed completely with this PR, hope you find the root cause why persistentDisposition is not appended to the pre hash string at the correct position yet. Hope my other edits are helpful/make sense.

Kind regards and thanks in advance; Ralph

Echsecutor commented 2 years ago

@RalphTro the code changes for this MR where already perfect, many thanks! Problems where

the checked in expected prefix string/hashes where not actually expected nor where those the ones produced by the code -> easy fix
what took me some time to figure out: the latest upstream gtin package seems broken leading to wrong conversions in our normalizer. I have now fixed the gtin version to 0.1.13. We might want to point this out to the gtin package developers